Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update app version name #WPB-11429 #3489

Merged
merged 3 commits into from
Oct 11, 2024
Merged

chore: Update app version name #WPB-11429 #3489

merged 3 commits into from
Oct 11, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Oct 8, 2024 •
edited by github-actions bot
Loading

StoryWPB-11429 [Android] update app version name to for fdroid auto update

What's new in this PR?

Update app version name to contain only the version ie 4.9.0 without version code and flavor. This will simplify fdroid integration.

Issues

There were issues with matching version name with tag for fdroid integration, thats why we're simplifying it.

Solutions

Version names generated contain only raw version name, the UI representation is build exactly as it was before so versionName-leastSignificantVersionCode-flavor

Testing

How to Test

Open the app and check in the settings that version name is in unchanged format ie 4.9.0-32599-beta so versionName-leastSignificantVersionCode-flavor

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: technical-debt Changes intended at mitigating risks label Oct 8, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 44.80%. Comparing base (ffd5445) to head (f626856).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ire/android/ui/settings/about/AboutThisAppState.kt 0.00% 2 Missing ⚠️
...android/ui/settings/about/AboutThisAppViewModel.kt 0.00% 2 Missing ⚠️
...c/main/kotlin/com/wire/android/util/AppNameUtil.kt 0.00% 2 Missing ⚠️
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% 1 Missing ⚠️
...otlin/com/wire/android/migration/UpdateReceiver.kt 0.00% 1 Missing ⚠️
...main/kotlin/com/wire/android/util/EmailComposer.kt 0.00% 1 Missing ⚠️
.../kotlin/com/wire/android/util/UserAgentProvider.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3489      +/-   ##
===========================================
- Coverage    44.81%   44.80%   -0.02%     
===========================================
  Files          466      467       +1     
  Lines        15766    15772       +6     
  Branches      2654     2654              
===========================================
  Hits          7066     7066              
- Misses        7939     7945       +6     
  Partials       761      761
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% <0.00%> (ø)
...otlin/com/wire/android/migration/UpdateReceiver.kt 18.18% <0.00%> (ø)
...main/kotlin/com/wire/android/util/EmailComposer.kt 0.00% <0.00%> (ø)
.../kotlin/com/wire/android/util/UserAgentProvider.kt 0.00% <0.00%> (ø)
...ire/android/ui/settings/about/AboutThisAppState.kt 0.00% <0.00%> (ø)
...android/ui/settings/about/AboutThisAppViewModel.kt 0.00% <0.00%> (ø)
...c/main/kotlin/com/wire/android/util/AppNameUtil.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd5445...f626856. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Built wire-android-staging-compat-pr-3489.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Built wire-android-dev-debug-pr-3489.apk is available for download

MohamadJaara
MohamadJaara requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are 2 places that need to be changed updated to include the lest significant digits of the code and the build flavour

  1. the template for bug report
  2. the debug screen

@m-zagorski
Copy link
Contributor Author

there are 2 places that need to be changed updated to include the lest significant digits of the code and the build flavour

  1. the template for bug report
  2. the debug screen

Indeed, my mistake. I've changed those places and also other ones which were using raw BuildConfig.VERSION_NAME to maintain consistency

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Oct 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Built wire-android-staging-compat-pr-3489.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Built wire-android-dev-debug-pr-3489.apk is available for download

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3489.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3489.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Oct 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 11, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Oct 11, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 11, 2024
@m-zagorski
chore: Update app version name #WPB-11429 (#3489)
be2d987
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2024
@m-zagorski m-zagorski added this pull request to the merge queue Oct 11, 2024
Merged via the queue into develop with commit e9c171a Oct 11, 2024
12 checks passed
@m-zagorski m-zagorski deleted the chore/update-app-version-name branch October 11, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@saleniuk saleniuk saleniuk approved these changes

Assignees

@m-zagorski m-zagorski

Labels
echoes: technical-debt Changes intended at mitigating risks size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@m-zagorski @CLAassistant @codecov-commenter @MohamadJaara @saleniuk